OPRUN-4207: Update feature-gate processing to support disabled features#144
Conversation
|
@tmshort: This pull request references OPRUN-4207 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
tmshort
force-pushed
the
disable-feature-gates
branch
from
6e2ec00 to
39f65b1
Compare
Some feature-gates are mutually exclusive, and we need to ensure that those feature-gates are not simultaneously enabled. In some cames, we need to disable upstream flags all the time (e.g. WebhookOperatorCertManager). This defines a function for each downstream feature-gate that defines how upstream feature-gate flags and arguments should be generated based whether that downstream feature-gate is enabled or disabled. Because these are functions that provides Helm values, they no longer need to be separated along OperatorController and Catalogd lines; the functions determine where the Helm parameters are set. Added unit tests, mostly written by Claude Code Assisted-by: Claude Code Signed-off-by: Todd Short <todd.short@me.com>
tmshort
force-pushed
the
disable-feature-gates
branch
from
39f65b1 to
0380780
Compare
|
/test openshift-e2e-aws |
|
/assign @bandrade |
|
Hi @bandrade , could you help test it? Thanks! |
|
/retest |
|
@tmshort: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-ci
bot
added
the
qe-approved
|
@tmshort: This pull request references OPRUN-4207 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
@bandrade: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5 participants
Some feature-gates are mutually exclusive, and we need to ensure that those feature-gates are not simultaneously enabled. In some cames, we need to disable upstream flags all the time (e.g. WebhookOperatorCertManager).
This defines a function for each downstream feature-gate that defines how upstream feature-gate flags and arguments should be generated based whether that downstream feature-gate is enabled or disabled. Because these are functions that provides Helm values, they no longer need to be separated along OperatorController and Catalogd lines; the functions determine where the Helm parameters are set.
Added unit tests, mostly written by Claude Code
Assisted-by: Claude Code